Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recursive calls into try_get_compiler when items are in the cache #1050

Merged
merged 1 commit into from
May 6, 2024
Merged

Avoid recursive calls into try_get_compiler when items are in the cache #1050

merged 1 commit into from
May 6, 2024

Conversation

dpaoliello
Copy link
Contributor

Have try_get_compiler provide the compiler path to is_flag_supported, and use get_base_compiler if called externally.

@dpaoliello dpaoliello mentioned this pull request May 3, 2024
Closed
NobodyXu
NobodyXu reviewed May 4, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes May 4, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes May 4, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@dpaoliello dpaoliello requested a review from NobodyXu May 4, 2024 00:43
@NobodyXu NobodyXu mentioned this pull request May 4, 2024
Open
NobodyXu
NobodyXu requested changes May 4, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
NobodyXu
NobodyXu approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit 385228f into rust-lang:main May 6, 2024
23 checks passed
@dpaoliello dpaoliello deleted the perf branch May 6, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpaoliello @NobodyXu